Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comscore pageview tracking #863

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Remove comscore pageview tracking #863

merged 3 commits into from
Jan 21, 2025

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to remove Comscore page views tracking as it has been decided here

Changes made

  • ComScorePageView as been removed.
  • ComScore.sendPageViewas been removed.
  • SRGAnalytics.sendPageView accept only CommandersActPageView.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Jan 20, 2025 that may be closed by this pull request
Remove comScore page view tracking #847
Closed
1 task
@StaehliJ StaehliJ requested a review from MGaetan89 January 20, 2025 09:40
@StaehliJ StaehliJ added this to the Analytics milestone Jan 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Code Coverage

Overall Project 52.01% -0.02% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-analytics 87.43% -0.52% 🟢
Files
Module File Coverage
:pillarbox-analytics ComScoreSrg.kt 89.91% 🟢
SRGAnalytics.kt 48.95% -3.68% 🟢
ComScore.kt 0% 🟢

@MGaetan89 MGaetan89 force-pushed the remove_comscore_pageview_tracking branch from 5088a6b to cc8de65 Compare January 21, 2025 13:27
@StaehliJ StaehliJ added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit eee45c9 Jan 21, 2025
9 checks passed
@MGaetan89 MGaetan89 deleted the remove_comscore_pageview_tracking branch January 21, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees

@StaehliJ StaehliJ

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
Analytics
Development

Successfully merging this pull request may close these issues.

Remove comScore page view tracking
2 participants
@StaehliJ @MGaetan89