feat(player): simplifies audio track handling #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Test suite run success131 tests passing in 9 suites. Report generated by 🧪jest coverage report action from b01c855 |
Resolves #38 by adding the `audioTrack` function to simplify audio track retrieval and selection. This function allows to: - retrieve the currently active audio track - activate an audio track based on `language` and `kind` properties Also, when selecting an audio track, if the `kind` property is not satisfied, the first audio track satisfying the `language` condition will be returned, or `undefined` if no condition is satisfied. ```javascript // Get the current audio track player.audioTrack(); // Activate an audio track player.audioTrack({language:'en', kind:'alternative'}) ``` - redefine default video.js `player` component - add `audioTrack` function - add a `typedefs` file to keep all types - add `trackSelector` type representing the track to be selected - add test coverage
amtins
force-pushed
the
feat/38-simplified-api-for-audio-track-selection
branch
from
5c39d4f to
b01c855
Compare
defagos
approved these changes
Oct 20, 2023
|
@defagos thanks for the review 👍🏽 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #38 by adding the
audioTrackfunction to simplify audio track retrieval and selection. This function allows to:languageandkindpropertiesAlso, when selecting an audio track, if the
kindproperty is not satisfied, the first audio track satisfying thelanguagecondition will be returned, orundefinedif no condition is satisfied.Changes made
playercomponentaudioTrackfunctiontypedefsfile to keep all typestrackSelectortype representing the track to be selected