Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add DRM support to demo page #68

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(demo): add DRM support to demo page #68

merged 1 commit into from
Nov 8, 2023

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Nov 8, 2023

Description

Closes #64

Changes made

Modified examples with license URLs to adhere to the expected video-js format of 'keySystems', specifying the vendor and URL as such :

{
  'title': '...',
  'src': ' ...',
  'keySystems': {
    'com.widevine.alpha': '...'
  }
}

Copy link

github-actions bot commented Nov 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 98.35% 477/485
🟢 Branches 93.42% 227/243
🟢 Functions 100% 137/137
🟢 Lines 99.14% 460/464

Test suite run success

142 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from a0f2ac7

Closes #64

Modified examples with license URLs to adhere to the expected video-js format of 'keySystems',
specifying the vendor and URL as such :

```javascript
{
  'title': '...',
  'src': ' ...',
  'keySystems': {
    'com.widevine.alpha': '...'
  }
}
```
@jboix jboix requested a review from amtins November 8, 2023 13:32
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amtins
Copy link
Member

amtins commented Nov 8, 2023

@jboix we should consider a way to add a license/certificate URL when loading a custom source. Of course de cheval, that would be another story.

@jboix jboix added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit e99567c Nov 8, 2023
3 checks passed
@amtins amtins deleted the feat/64-drm-demo branch November 8, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo add DRM support
3 participants