Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-1277 Remove most searched shows #526

Closed
wants to merge 1 commit into from

Conversation

mutaben
Copy link
Collaborator

@mutaben mutaben commented Nov 21, 2024

Description

The legacy Social View is being shutdown, and some calls won't have a successor.

Most searched is one of them, that's why everything associated with it needs to be removed.

Although I'm fairly certain nothing would break and it just wouldn't show up when returning nothing, it's still good ro remove clutter from code.

Changes Made

  • Remove calls and aspects related to most searched

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Nov 21, 2024
@mutaben mutaben requested review from defagos and pyby November 21, 2024 14:36
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1277-most-searched-removal November 21, 2024 14:39 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1277-most-searched-removal November 21, 2024 14:39 Inactive
Copy link
Contributor

@Loic-Dumas Loic-Dumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is not needed since the "most searched shows" call will be fixed later. So no need to remove code now, as long empty list result are hidden in the search.

@mutaben
Copy link
Collaborator Author

mutaben commented Nov 22, 2024

Closing pull request since the call will be replaced later.

The current behavior is to ignore the section anyway if the result is empty, so it should work without doing anything.

@mutaben mutaben closed this Nov 22, 2024
@mutaben mutaben deleted the PLAYNEXT-1277-most-searched-removal branch November 25, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants