Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-1823 Always show media title in description title field #532

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

mutaben
Copy link
Collaborator

@mutaben mutaben commented Jan 16, 2025

Description

Issue on SRF DOK media title

An issue was raised about some medias only showing air date instead of their title.

After investigating, I found out that it was done on purpose and explained the situation in the ticket that reported this issue.

I was asked to remove entirely this logic and always show the media title.

Changes Made

  • Remove the customization based on redundancy and always show media title instead

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1823-air-date-instead-of-title January 16, 2025 16:53 Inactive
@mutaben mutaben requested a review from pyby January 17, 2025 10:08
@mutaben mutaben added the bug Issue to be fix (issue and PR) - release notes section label Jan 17, 2025
@mutaben mutaben marked this pull request as ready for review January 17, 2025 10:09
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1823-air-date-instead-of-title January 17, 2025 10:12 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1823-air-date-instead-of-title January 17, 2025 10:13 Inactive
@mutaben mutaben requested a review from pyby January 20, 2025 08:42
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1823-air-date-instead-of-title January 20, 2025 08:45 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1823-air-date-instead-of-title January 20, 2025 08:46 Inactive
@mutaben mutaben added this pull request to the merge queue Jan 21, 2025
@mutaben mutaben removed this pull request from the merge queue due to a manual request Jan 21, 2025
@mutaben mutaben added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit d4c8f6a Jan 21, 2025
4 checks passed
@mutaben mutaben deleted the PLAYNEXT-1823-air-date-instead-of-title branch January 21, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants