Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-1964 PLAYNEXT-1634: StreamLater & ContinueListening sections integration #541

Conversation

mutaben
Copy link
Collaborator

@mutaben mutaben commented Feb 6, 2025

Description

In order to implement the new PAC audio sections, two new types of ContentPresentation were added.

  • The first is ContinueStreaming which replaces ContinueListening (analogous to ContinueWatching)
  • The second is StreamLater, analogous to WatchLater

You can see this in the currently opened in SRGDataProvider.

This PR points to those changes and integrate them in order to be able to handle this new kind of content.

Changes Made

  • Point to the branch of the PR in SRGDataProvider with the wanted changes (ideally we would like to have those released before we merge this PR)
  • Treat ContinueStreaming like ContinueWatching
  • Treat StreamLater like WatchLater

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Feb 6, 2025
@mutaben mutaben marked this pull request as ready for review February 7, 2025 14:11
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1964-PLAYNEXT-1634-streamlater-continuelistening-sections-integration February 7, 2025 14:37 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1964-PLAYNEXT-1634-streamlater-continuelistening-sections-integration February 7, 2025 14:50 Inactive
@mutaben mutaben added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit e04ad9f Feb 13, 2025
3 of 5 checks passed
@mutaben mutaben deleted the PLAYNEXT-1964-PLAYNEXT-1634-streamlater-continuelistening-sections-integration branch February 13, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants