Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation warnings and enable the -Werror flag in CI #473

Merged
merged 4 commits into from
Nov 18, 2023
Merged

fix compilation warnings and enable the -Werror flag in CI #473

merged 4 commits into from
Nov 18, 2023

Conversation

ahmed-irfan
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 1, 2023 •
edited
Loading

Coverage Status

coverage: 65.146% (+0.002%) from 65.144%
when pulling f627fce on fix-compilation-warnings
into f2241ce on master.

@ahmed-irfan ahmed-irfan marked this pull request as draft November 1, 2023 22:43
@ahmed-irfan ahmed-irfan mentioned this pull request Nov 10, 2023
Merged
@ahmed-irfan ahmed-irfan marked this pull request as ready for review November 17, 2023 18:27
@ahmed-irfan ahmed-irfan self-assigned this Nov 18, 2023
@ahmed-irfan ahmed-irfan changed the title fix compilation warnings fix compilation warnings and enable the -Werror flag in CI Nov 18, 2023
@ahmed-irfan ahmed-irfan requested a review from disteph November 18, 2023 21:22
@ahmed-irfan ahmed-irfan removed their assignment Nov 18, 2023
@disteph disteph merged commit fc50eb4 into master Nov 18, 2023
26 checks passed
@ahmed-irfan ahmed-irfan deleted the fix-compilation-warnings branch November 18, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disteph disteph Awaiting requested review from disteph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmed-irfan @coveralls @disteph