child: add extra args in correct order #7727
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the arguments where added in backwards order. Insted: `-A -B -C value` it appened `value -C -B -A`, which caused issues with value arguments. This commit refactors the code to add all arguments in natural order starting from argv[0]..argv[argc] instead of attempting to create argv from the end argv[argc]..argv[0] which can easily create confusion. Also switched to talloc_zero_array() to handle NULL more intuitively.
|
This is required to make #7678 working. |
andreboscatto
added
branch: sssd-2-9
branch: sssd-2-10
no-backport
|
As we agreed, we will do #7678 first and this one will land only the master branch. Setting blocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the arguments where added in backwards order. Insted:
-A -B -C valueit appenedvalue -C -B -A, which caused issues withvalue arguments.
This commit refactors the code to add all arguments in natural order
starting from argv[0]..argv[argc] instead of attempting to create argv
from the end argv[argc]..argv[0] which can easily create confusion.
Also switched to talloc_zero_array() to handle NULL more intuitively.