tests: Remove pytest assertion about exception #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-stephenson
force-pushed
the
analyze_child_logs_exception_fix
branch
from
a00f465 to
ed5e353
Compare
|
I don't think this is correct. According to connect documentation a SSHAuthenticationError exception should be raised if user fails to authenticate. Thus, it makes sense to keep checking for it to raise when an incorrect password has been input. I'd suggest checking whether the authentication has succeeded (sssd bug) or python ssh isn't behaving correctly (LibsshSessionException bug). |
|
I agree with @ikerexxe, we have to find out why the behavior changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why but previously this line below was raising a
SSHAuthenticationErrorexception with a wrong password SSH attempt, and now it doesn't.This
pytest raisesassertion is not necessary for this test in my opinion however.