Fixed url format custom rule to ignore root link

SSWConsulting · Apr 30, 2024 · 2756c10 · 2756c10
1 parent 015ce97
commit 2756c10
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/docker/customHtmlRules.js b/docker/customHtmlRules.js
@@ -320,7 +320,7 @@ exports.addCustomHtmlRule = async (apiToken, url) => {
         var tagName = event.tagName.toLowerCase(),
           mapAttrs = parser.getMapAttrs(event.attrs);
         if (tagName === "a") {
-          if (mapAttrs["href"]) {
+          if (mapAttrs["href"] && mapAttrs["href"] !== "/") {
             if (
               mapAttrs["href"].substr(mapAttrs["href"].length - 1) === "/" ||
               mapAttrs["href"].substr(mapAttrs["href"].length - 1) === "."

diff --git a/docker/test/html-rules-testing/url-must-be-formatted-correctly.spec.js b/docker/test/html-rules-testing/url-must-be-formatted-correctly.spec.js
@@ -20,6 +20,12 @@ describe(`Rules: ${ruldId}`, () => {
     expect(messages.length).to.be(1);
   });
 
+  it('URL with only "/" should not result in an error', () => {
+    const code = '<a href="/" />';
+    const messages = HTMLHint.verify(code, ruleOptions);
+    expect(messages.length).to.be(0);
+  });
+
   it("Correctly formatted URL with space should not result any error", () => {
     const code = '<a href="www.ssw.com.au/This is a rule" />';
     const messages = HTMLHint.verify(code, ruleOptions);