Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed email address custom rule #680

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fixed email address custom rule #680

merged 1 commit into from
Oct 3, 2023

Conversation

tombui99
Copy link
Contributor

@tombui99 tombui99 commented Oct 3, 2023 •
edited
Loading

#679

  • Custom rule should check for all texts that contain email addresses even for the ones inside code and a tags
  • Added additional unit test case for email address in a normal <p> tag
  • Added additional check to check for email addresses in href attribute
  • Removed unit test for disabled 'Youtube' custom rule

zacharykeeping
zacharykeeping approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@zacharykeeping zacharykeeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharykeeping zacharykeeping merged commit 96d41f2 into staging Oct 3, 2023
@tombui99 tombui99 mentioned this pull request Oct 5, 2023
Closed
2 tasks
@tombui99 tombui99 deleted the fix-email-address-rule branch October 6, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharykeeping zacharykeeping zacharykeeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombui99 @zacharykeeping