Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help and allow editing for ignored URLs #686

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Oct 5, 2023

#675

Adds some help text to the Ignore URL modal, and allows for editing the duration of an ignored URL in the Settings page.

Screenshot 2023-10-06 at 10 22 26 am

Figure: Additional help text in modal

Screenshot 2023-10-06 at 10 22 43 am

Figure: Settings page has a new edit button on ignored URLs

Screenshot 2023-10-06 at 10 22 54 am

Figure: Clicking the edit button allows for changing the duration

@zacharykeeping zacharykeeping marked this pull request as ready for review October 5, 2023 23:25
Copy link
Contributor

@tombui99 tombui99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombui99 tombui99 merged commit 6750807 into staging Oct 6, 2023
1 check passed
@tombui99 tombui99 deleted the ignore-modal-updates branch October 6, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants