Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed spelling mistake custom rule reporting false positive #721

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fixed spelling mistake custom rule reporting false positive #721

merged 1 commit into from
Oct 23, 2023

Conversation

tombui99
Copy link
Contributor

#693

  • Added check to make sure the spelling mistake character has space and is not part of a long single string
  • Added more unit tests

zacharykeeping
zacharykeeping approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@zacharykeeping zacharykeeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharykeeping zacharykeeping merged commit 9e31df4 into staging Oct 23, 2023
@tombui99 tombui99 deleted the fix-false-positive-spelling-mistake-rule branch October 23, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharykeeping zacharykeeping zacharykeeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombui99 @zacharykeeping