Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter unscannable links in UI #733

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Oct 24, 2023

#730

This disables the UI filtering of unscannable links as these links should already be scanned with more accurate GET requests.

Not stripping it out completely just yet as we may revisit in the future if we change our HEAD/GET handling.

Screenshot 2023-10-24 at 5 12 49 pm

Figure: Links like these are now displayed accurately in the list

@zacharykeeping zacharykeeping marked this pull request as ready for review October 24, 2023 06:11
Copy link
Contributor

@tombui99 tombui99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombui99 tombui99 merged commit 5086bea into staging Oct 24, 2023
1 check passed
@tombui99 tombui99 deleted the unscannable-links-fix branch October 25, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants