Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve custom option form fields #748

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Improve custom option form fields #748

merged 1 commit into from
Nov 1, 2023

Conversation

tombui99
Copy link
Contributor

@tombui99 tombui99 commented Nov 1, 2023

  • Added dropdown select box to choose country code instead of text input

image

  • Added constants to define input type for each rule

zacharykeeping
zacharykeeping approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@zacharykeeping zacharykeeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zacharykeeping zacharykeeping merged commit 4f00e6a into staging Nov 1, 2023
1 check passed
@zacharykeeping zacharykeeping deleted the improve-custom-option-input branch November 1, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharykeeping zacharykeeping zacharykeeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombui99 @zacharykeeping