Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom option UI from designer feedback #758

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix custom option UI from designer feedback #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui/src/components/htmlhintcomponents/UpdateHTMLRules.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,9 +358,9 @@
on:keypress={undefined}
><i class="fas fa-pen-to-square"></i> Edit</button>
</span>
<div class="bggrey mt-2">
<div class="bggrey ml-4 mr-5">
{#if customHtmlRuleOptions && customHtmlRuleOptions.length > 0 && customHtmlRuleOptions.find(x => x.ruleId === rule.rule)?.optionValue.length > 0}
<div class="ml-5">
<div class="p-3">
<span class="font-sans font-bold">
Applied custom option value:
</span>
Expand All @@ -370,7 +370,7 @@
</div>
{/if}
{#if currSelectedCustomOption === index}
<div class="ml-5 mb-3">
<div class="p-3">
<div>
{rule.customOptionsMessage}
</div>
Expand Down
4 changes: 2 additions & 2 deletions ui/src/utils/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ export const customHtmlHintRules = [
ruleLink: "https://www.ssw.com.au/rules/do-you-know-to-hyperlink-your-phone-numbers",
type: RuleType.Warning,
isEnableCustomOptions: true,
customOptionsMessage: 'Please choose your country code:',
customOptionsMessage: 'Please choose the country code:',
customOptionInputType: customOptionInputType.dropDown,
customOptionDropdownValues: countryCodes
},
Expand Down Expand Up @@ -588,7 +588,7 @@ export const customHtmlHintRules = [
ruleLink: "https://ssw.com.au/rules/avoid-absolute-internal-links/",
type: RuleType.Warning,
isEnableCustomOptions: true,
customOptionsMessage: 'Please enter your website internal URL:',
customOptionsMessage: 'Please enter the website internal URL:',
customOptionInputType: customOptionInputType.singleTextBox,
customOptionInputValueType: 'url'
},
Expand Down