Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter and sort on all results on Scan Results page #761

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Filter and sort on all results on Scan Results page #761

merged 2 commits into from
Nov 9, 2023

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Nov 9, 2023 •
edited
Loading

#760

This fixes an issue where the Public Scans list doesn't actually return the last 500 results as Table Storage is sorting based on PartitionKey first.

@zacharykeeping zacharykeeping changed the title Filter and sort on all results Filter and sort on all results on Scan Results page Nov 9, 2023
tombui99
tombui99 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@tombui99 tombui99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombui99 tombui99 merged commit b85c4c1 into staging Nov 9, 2023
@tombui99 tombui99 deleted the all-sort-fix branch November 9, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombui99 tombui99 tombui99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharykeeping @tombui99