Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Staging to Main #762

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Merge Staging to Main #762

merged 14 commits into from
Nov 9, 2023

Conversation

tombui99
Copy link
Contributor

@tombui99 tombui99 commented Nov 9, 2023

No description provided.

const functionHost = '-sswlinkauditor-c1131.cloudfunctions.net';

// Disallow fetching from same host to prevent request forgery
if (target.hostname.includes(functionHost) || target.hostname === 'localhost') {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
-sswlinkauditor-c1131.cloudfunctions.net
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
return;
}

const resp = await fetch(target.href).catch((err) => {

Check failure

Code scanning / CodeQL

Server-side request forgery Critical

The
URL
of this request depends on a
user-provided value
.
@zacharykeeping zacharykeeping merged commit a73d7c0 into main Nov 9, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants