Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ CI/CD | Update workflows with gated deployments #914

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

zacharykeeping
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #913

  1. What was changed?
  1. Updates the GitHub Workflows to use a single workflow triggered from main with two gated deployments to Staging and Production.
  2. Updates the contributing guide with the new deployment flow.
  1. Did you do pair or mob programming?

No

@zacharykeeping zacharykeeping changed the title Update workflows with gated deployments ♻️ Update workflows with gated deployments Jun 20, 2024
@zacharykeeping zacharykeeping changed the title ♻️ Update workflows with gated deployments ♻️ CI/CD | Update workflows with gated deployments Jun 20, 2024
@zacharykeeping zacharykeeping marked this pull request as ready for review June 20, 2024 04:59
@zacharykeeping zacharykeeping requested review from amankumarrr and removed request for william-liebenberg September 13, 2024 00:18
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! just left a small comment for a better readability.

uses: ./.github/workflows/test-build.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we prefix it with the template- for more readability as it is just a callable pipeline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those pipelines that are only triggered by calling, I think those should be prefixed with that.

@zacharykeeping zacharykeeping merged commit 206a89a into main Sep 13, 2024
4 checks passed
@zacharykeeping zacharykeeping deleted the workflow-update branch September 13, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👷 CI/CD | Move to gated deployments
2 participants