Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ ✏️ Renamed file for rule 'Operations - Do you have a company compliance sheet?' #9528

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Calinator444
Copy link
Member

Description

The file for this rule was incorrectly named, causing it to break the validation check

Copy link
Contributor

github-actions bot commented Nov 4, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code -
Total -

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title ✏️ Renamed file for rule 'Operations - Do you have a company compliance sheet?' XS✔ ◾ ✏️ Renamed file for rule 'Operations - Do you have a company compliance sheet?' Nov 4, 2024
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Nov 4, 2024
@Calinator444
Copy link
Member Author

@JimmyChenSSW

Hey @JimmyChenSSW

When you wrote the rule "Operations - Do you have a company compliance sheet" did you use Decap or create the file manually?

Just trying to figure out how we wound up with a rule that has the wrong file name

@JimmyChenSSW
Copy link
Contributor

When you wrote the rule "Operations - Do you have a company compliance sheet" did you use Decap or create the file manually?

I created the file manually, I think that is why I wrote the title the other way.

I didn't use Decap to create rules, because if my repo was out of sync, it would be an issue in using Decap (someone suggested me use GitHub directly before).

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old labels Nov 4, 2024
@tiagov8 tiagov8 merged commit f2bd1aa into main Nov 4, 2024
@tiagov8 tiagov8 deleted the rename-compliance-sheet-rule branch November 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐓 - Old About 32 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants