Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming conventions #9539

Merged
merged 14 commits into from
Nov 5, 2024
Merged

Update naming conventions #9539

merged 14 commits into from
Nov 5, 2024

Conversation

matt-goldman-ssw
Copy link
Contributor

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Email subject : "🎥 Rules - Naming Conventions with Matt Goldman"

  1. What was changed?

The naming conventions rule (https://www.ssw.com.au/rules/follow-naming-conventions/) does not currently contain any naming conventions.

I have archived that rule, and added 9 new rules

  1. Did you do pair or mob programming (list names)?

N/A

@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old and removed Age: 🥚 - New About 2 hours old labels Nov 5, 2024
danielmackay
danielmackay requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comments and suggestions, but a couple of typos that need to be fixed.

matt-goldman-ssw and others added 9 commits November 5, 2024 16:07
@matt-goldman-ssw @danielmackay
Update rules/avoid-generic-names/rule.md
94592e2 
Co-authored-by: Daniel Mackay [SSW] <[email protected]>
@matt-goldman-ssw @danielmackay
Update rules/avoid-using-your-name-in-client-code/rule.md
2b9ec88 
Co-authored-by: Daniel Mackay [SSW] <[email protected]>
@matt-goldman-ssw @danielmackay
Update rules/avoid-generic-names/rule.md
13e7c5f 
Co-authored-by: Daniel Mackay [SSW] <[email protected]>
@matt-goldman-ssw
Added details about helper
2f4fa5f
@matt-goldman-ssw @danielmackay
Update rules/use-meaningful-modifiers/rule.md
be0251a 
Co-authored-by: Daniel Mackay [SSW] <[email protected]>
@matt-goldman-ssw @danielmackay
Update rules/verbs-for-method-names/rule.md
24c48b9 
Co-authored-by: Daniel Mackay [SSW] <[email protected]>
@matt-goldman-ssw
Fix meadningful typo
73daadf
@matt-goldman-ssw
Merge branch 'update-naming-conventions' of https://github.com/matt-g…
b23dcdd 
…oldman-ssw/SSW.Rules.Content into update-naming-conventions
@matt-goldman-ssw @danielmackay
Update rules/when-to-use-technical-terms/rule.md
6027685 
Co-authored-by: Daniel Mackay [SSW] <[email protected]>
danielmackay
danielmackay approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt-goldman-ssw matt-goldman-ssw merged commit 663a56d into SSWConsulting:main Nov 5, 2024
5 checks passed
@matt-goldman-ssw matt-goldman-ssw deleted the update-naming-conventions branch November 5, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmackay danielmackay danielmackay approved these changes

@adamcogan adamcogan Awaiting requested review from adamcogan

@drwharris drwharris Awaiting requested review from drwharris

@bradystroud bradystroud Awaiting requested review from bradystroud

@MattParkerDev MattParkerDev Awaiting requested review from MattParkerDev

@Calinator444 Calinator444 Awaiting requested review from Calinator444

@lukecookssw lukecookssw Awaiting requested review from lukecookssw

@AntPolkanov AntPolkanov Awaiting requested review from AntPolkanov

Assignees
No one assigned
Labels
Age: 🐣 - Young About 4 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-goldman-ssw @danielmackay