Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ nouns for class names - fix date #9627

Merged
merged 1 commit into from
Nov 28, 2024
Merged

XS✔ ◾ nouns for class names - fix date #9627

merged 1 commit into from
Nov 28, 2024

Conversation

bradystroud
Copy link
Member

@bradystroud bradystroud commented Nov 28, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

saw this bug
image

should be fixed by making the uri consistent with the folder name
image

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code -
Total -

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title nouns for class names - fix date XS✔ ◾ nouns for class names - fix date Nov 28, 2024
jeoffreyfischer
jeoffreyfischer approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jeoffreyfischer jeoffreyfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradystroud bradystroud merged commit a0d24c6 into main Nov 28, 2024
7 checks passed
@bradystroud bradystroud deleted the bradystroud-patch-17 branch November 28, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeoffreyfischer jeoffreyfischer jeoffreyfischer approved these changes

Assignees
No one assigned
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradystroud @jeoffreyfischer