Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💸 Megamenu - Bundle Size Too Large #1357

Closed
1 of 2 tasks
Harry-Ross opened this issue Sep 6, 2023 · 4 comments · Fixed by #1384
Closed
1 of 2 tasks

💸 Megamenu - Bundle Size Too Large #1357

Harry-Ross opened this issue Sep 6, 2023 · 4 comments · Fixed by #1384
Assignees

Comments

@Harry-Ross
Copy link
Contributor

Harry-Ross commented Sep 6, 2023

Description
Right now, the megamenu size is much too large - this is likely due to bundling npm depdendencies that could be classified as peerDependencies.

I have created an issue on SSW.Megamenu here: SSWConsulting/SSW.MegaMenu#40

Proposed solution
I will be moving as many NPM packages as possible to peer dependencies/removing the dependency where possible.

Tasks

@Harry-Ross Harry-Ross self-assigned this Sep 6, 2023
@github-project-automation github-project-automation bot moved this to 🤷‍♂️ Needs Triage in SSW.Website Sep 6, 2023
@Harry-Ross Harry-Ross moved this from 🤷‍♂️ Needs Triage to 🏗 In progress in SSW.Website Sep 6, 2023
@Harry-Ross Harry-Ross changed the title 💸 {{ TITLE }} 💸 Megamenu - Bundle Size Too Large Sep 6, 2023
@johnxu16
Copy link
Contributor

johnxu16 commented Sep 7, 2023

In optimizing the size of the package, could you please move those image assets to remote so we can utilize speed from cdn, etc?

They take around 190kb(60%) space.

@Harry-Ross
Copy link
Contributor Author

Created a PR at SSWConsulting/SSW.MegaMenu#41

@Harry-Ross
Copy link
Contributor Author

SSW Rules issue: SSWConsulting/SSW.Rules#1097
SSW People issue: SSWConsulting/SSW.People#532

@Harry-Ross
Copy link
Contributor Author

Menu JSON to be merged when all tasks completed: SSWConsulting/SSW.Website.Menu.json#99

@Harry-Ross Harry-Ross moved this from 👀 In review to 🏗 In progress in SSW.Website Sep 11, 2023
@Harry-Ross Harry-Ross moved this from 🏗 In progress to 👀 In review in SSW.Website Sep 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in SSW.Website Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants