💸 Mega Menu - Reduced Bundle Size #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1384.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1384.azurewebsites.net |
bradystroud
requested changes
Sep 12, 2023
|
Seems to be looking for images using a relative link 
|
Correct, as per SSWConsulting/SSW.Website.Menu.json#99 - this change will fix the images not showing up, but deployments must be coordinated with SSW.People and SSW.Rules to ensure no broken menu across each site. |
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1384.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1384.azurewebsites.net |
bradystroud
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected routes: *
Fixes 💸 Megamenu - Bundle Size Too Large #1357