Fixed SonarCloud task void issues related #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
samatstariongroup
requested changes
Mar 18, 2021
| @@ -270,7 +290,7 @@ private void Execute(ISession session, UserRuleVerification userRuleVerification | |||
| /// <param name="ruleVerification"> | |||
| /// The <see cref="RuleVerification"/> that is to be updated. | |||
| /// </param> | |||
| private async void UpdateExecutedOn(ISession session, RuleVerification ruleVerification) | |||
| private void UpdateExecutedOn(ISession session, RuleVerification ruleVerification) | |||
There was a problem hiding this comment.
probably best to make this private async Task ...
| /// <summary> | ||
| /// The Logger. | ||
| /// </summary> | ||
| private static Logger logger = LogManager.GetCurrentClassLogger(); |
There was a problem hiding this comment.
better to add more logging instead of removing the logger
| @@ -262,13 +237,14 @@ private async void ExecuteOk() | |||
| var dal = this.dals.Single(x => x.Metadata.DalType == DalType.File); | |||
| var dalInstance = (IDal)Activator.CreateInstance(dal.Value.GetType()); | |||
|
|
|||
| var fileExportSession = new Session(dalInstance, creds); | |||
| _ = new Session(dalInstance, creds); | |||
There was a problem hiding this comment.
not happy about the _ does not make it more readible, please revert
| @@ -494,7 +478,7 @@ private async void CreateBinaryRelationship(DiagramConnector connector) | |||
| try | |||
| { | |||
| var operationContainer = containerTransaction.FinalizeTransaction(); | |||
| await this.Session.Write(operationContainer); | |||
| this.Session.Write(operationContainer).GetAwaiter().GetResult(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description