[Update] auto generated rowviewmodels and dialogviewmodel #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -73,6 +108,33 @@ public string Name | |||
| set { this.RaiseAndSetIfChanged(ref this.name, value); } | |||
| } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
3 added properties. Is that correct?
| } | ||
| else | ||
| { | ||
| this.OwnerName = string.Empty; |
There was a problem hiding this comment.
not 100% backwards compatible
| @@ -36,9 +57,28 @@ public partial class AndExpressionRowViewModel : BooleanExpressionRowViewModel<A | |||
| /// <param name="containerViewModel">The <see cref="IViewModelBase{Thing}"/> that is the container of this <see cref="IRowViewModelBase{Thing}"/></param> | |||
| public AndExpressionRowViewModel(AndExpression andExpression, ISession session, IViewModelBase<Thing> containerViewModel) : base(andExpression, session, containerViewModel) | |||
| { | |||
| this.UpdateProperties(); | |||
There was a problem hiding this comment.
New code. Correct?
| @@ -101,9 +121,8 @@ protected override void ObjectChangeEventHandler(ObjectChangedEvent objectChange | |||
| /// </summary> | |||
| private void UpdateProperties() | |||
| { | |||
| this.ModifiedOn = this.Thing.ModifiedOn; | |||
There was a problem hiding this comment.
Are you sure that ModifiedOn should be removed from the code?
There was a problem hiding this comment.
yes, this has been moved to RowViewModelBase as it is a property of Thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Update RowViewModel: