Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate changing of the ISession.Read(Iteration iteration, DomainOfExpertise domain) method signature #745 #167

Closed
3 tasks done
adrianchivu opened this issue Feb 11, 2021 · 0 comments · Fixed by #169
Closed
3 tasks done

Investigate changing of the ISession.Read(Iteration iteration, DomainOfExpertise domain) method signature #745 #167

adrianchivu opened this issue Feb 11, 2021 · 0 comments · Fixed by #169
Assignees
@adrianchivu
Labels
0.5sp investigation SDK
Milestone
sprint 27

Comments

@adrianchivu
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the CDP4-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

Investigate changing of the ISession.Read method signature in order to allow passing of a cancelation token.
This was referenced Feb 11, 2021
Closed
Closed
@adrianchivu adrianchivu self-assigned this Feb 12, 2021
@lxatstariongroup lxatstariongroup added this to the sprint 27 milestone Feb 12, 2021
@adrianchivu adrianchivu mentioned this issue Feb 15, 2021
Merged
4 tasks
@cozminvelciu cozminvelciu linked a pull request Feb 26, 2021 that will close this issue
#167 Investigate changing of the ISession.Read(Iteration iteration, DomainOfExpertise domain) method signature #169
Merged
4 tasks
lxatstariongroup pushed a commit that referenced this issue Mar 11, 2021
@adrianchivu
Fixes #167 Investigate changing of the ISession.Read(Iteration iterat…
9686744 
…ion, DomainOfExpertise domain) method signature (#169)

* Initial implementation.
* Fix concurrency issue.
* Remove unusefull string interpolation.
* Improve test coverage.
* Improve test coverage.
* Mark test WebServicesDependent.
* Actions performed on Sam's suggestions:
* Implement try catch finally with TryRemove in all methods
* Fix typos
* Fix methods summaries
This was referenced May 6, 2021
Closed
Closed
Closed
@samatstariongroup samatstariongroup moved this to Done in COMET-CE Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianchivu adrianchivu

Labels
0.5sp investigation SDK
Projects
COMET-CE
Archived in project
Milestone
sprint 27
2 participants
@adrianchivu @lxatstariongroup