Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167 Investigate changing of the ISession.Read(Iteration iteration, DomainOfExpertise domain) method signature #169

Merged
merged 7 commits into from
Mar 11, 2021
Merged

#167 Investigate changing of the ISession.Read(Iteration iteration, DomainOfExpertise domain) method signature #169

merged 7 commits into from
Mar 11, 2021

Conversation

adrianchivu
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the CDP4-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

@adrianchivu adrianchivu self-assigned this Feb 15, 2021
@adrianchivu adrianchivu marked this pull request as draft February 15, 2021 11:41
@adrianchivu
Copy link
Contributor Author

adrianchivu commented Feb 15, 2021 •
edited
Loading

Linked issue: #167

@adrianchivu
Copy link
Contributor Author

adrianchivu commented Feb 17, 2021 •
edited
Loading

@alexatrhea The code coverage is low for this branch. Should I spent time to boost the code coverage ?

@adrianchivu adrianchivu marked this pull request as ready for review February 17, 2021 08:41
@cozminvelciu cozminvelciu modified the milestones: 26, sprint 26 Feb 26, 2021
@cozminvelciu cozminvelciu linked an issue Feb 26, 2021 that may be closed by this pull request
Investigate changing of the ISession.Read(Iteration iteration, DomainOfExpertise domain) method signature #745 #167
Closed
3 tasks
@adrianchivu
Copy link
Contributor Author

@samatrhea please take a look. Thank you.

samatstariongroup
samatstariongroup requested changes Feb 26, 2021
View reviewed changes
CDP4Dal/Session.cs Outdated Show resolved Hide resolved
CDP4Dal/Session.cs Show resolved Hide resolved
CDP4Dal/Session.cs Outdated Show resolved Hide resolved
CDP4Dal/Session.cs Show resolved Hide resolved
CDP4Dal/Session.cs Outdated Show resolved Hide resolved
CDP4Dal/Session.cs Show resolved Hide resolved
CDP4Dal/Session.cs Outdated Show resolved Hide resolved
CDP4Dal/Session.cs Show resolved Hide resolved
CDP4Dal/Session.cs Show resolved Hide resolved
CDP4Dal/Session.cs Show resolved Hide resolved
Actions performed on Sam's suggestions:
f728a45 
* Implement try catch finally with TryRemove in all methods
* Fix typos
* Fix methods summaries
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.2% 40.2% Coverage
0.0% 0.0% Duplication

lxatstariongroup
lxatstariongroup approved these changes Mar 2, 2021
View reviewed changes
CDP4Dal/Session.cs Show resolved Hide resolved
samatstariongroup
samatstariongroup approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@lxatstariongroup lxatstariongroup merged commit 9686744 into development Mar 11, 2021
@lxatstariongroup lxatstariongroup deleted the feat/GH167-Investigate-changing-of-the-ISession-Read branch March 11, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cozminvelciu cozminvelciu cozminvelciu left review comments

@lxatstariongroup lxatstariongroup lxatstariongroup approved these changes

@alexatstariongroup alexatstariongroup alexatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

Assignees

@adrianchivu adrianchivu

Labels
SDK
Projects
None yet
Milestone
sprint 26
Development

Successfully merging this pull request may close these issues.

Investigate changing of the ISession.Read(Iteration iteration, DomainOfExpertise domain) method signature #745
5 participants
@adrianchivu @samatstariongroup @alexatstariongroup @lxatstariongroup @cozminvelciu