Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for session open/read silently #193

Closed
3 tasks done
adrianchivu opened this issue Jul 8, 2021 · 0 comments · Fixed by #194
Closed
3 tasks done

Support for session open/read silently #193

adrianchivu opened this issue Jul 8, 2021 · 0 comments · Fixed by #194
Assignees
@adrianchivu
Labels
1sp
Milestone
sprint 39

Comments

@adrianchivu
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the COMET-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

Extend Session.Read and Session.Open methods to enable/disable CDPMessageBus notifications.
@adrianchivu adrianchivu linked a pull request Jul 8, 2021 that will close this issue
#193 Support for open read silently #194
Merged
4 tasks
@adrianchivu adrianchivu added the 1sp label Jul 8, 2021
@adrianchivu adrianchivu self-assigned this Jul 8, 2021
@adrianchivu adrianchivu changed the title Support for open read silently Support for session open/read silently Jul 8, 2021
alexatstariongroup pushed a commit that referenced this issue Jul 8, 2021
@adrianchivu
#193 Support for open read silently (#194)
fe5dc96 
* Initial implementation.

* Bump SDK version.

* Change Open, Read methods implementation and remove OpenSilently & ReadSilently.

* Mesage bus changes.

* Replace methods with getter/setter for the value that indicates availability of the message bus.

* Set proper visibility of the property.

* Update appveyor.yml

Co-authored-by: Adrian Chivu <[email protected]>
Co-authored-by: Alex Vorobiev <[email protected]>
@alexatstariongroup alexatstariongroup added this to the sprint 39 milestone Aug 30, 2021
@samatstariongroup samatstariongroup moved this to Done in COMET-CE Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianchivu adrianchivu

Labels
1sp
Projects
COMET-CE
Archived in project
Milestone
sprint 39
Development

Successfully merging a pull request may close this issue.

#193 Support for open read silently STARIONGROUP/COMET-SDK-Community-Edition
2 participants
@alexatstariongroup @adrianchivu