Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#193 Support for open read silently #194

Merged
merged 7 commits into from
Jul 8, 2021
Merged

#193 Support for open read silently #194

merged 7 commits into from
Jul 8, 2021

Conversation

adrianchivu
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

@adrianchivu adrianchivu self-assigned this Jul 8, 2021
@adrianchivu adrianchivu linked an issue Jul 8, 2021 that may be closed by this pull request
Support for session open/read silently #193
Closed
3 tasks
samatstariongroup
samatstariongroup requested changes Jul 8, 2021
View reviewed changes
CDP4Dal/ISession.cs Outdated Show resolved Hide resolved
CDP4Dal/Session.cs Outdated Show resolved Hide resolved
CDP4Common/CDP4Common.csproj Show resolved Hide resolved
CDP4Dal/ISession.cs Outdated Show resolved Hide resolved
CDP4Dal/ISession.cs Outdated Show resolved Hide resolved
CDP4Dal/Session.cs Outdated Show resolved Hide resolved
CDP4JsonSerializer/CDP4JsonSerializer.csproj Show resolved Hide resolved
CDP4Rules/CDP4Rules.csproj Show resolved Hide resolved
alexatstariongroup
alexatstariongroup requested changes Jul 8, 2021
View reviewed changes
CDP4Dal/ISession.cs Outdated Show resolved Hide resolved
samatstariongroup
samatstariongroup requested changes Jul 8, 2021
View reviewed changes
CDP4Dal/CDPMessageBus.cs Show resolved Hide resolved
CDP4Dal/CDPMessageBus.cs Outdated Show resolved Hide resolved
samatstariongroup
samatstariongroup requested changes Jul 8, 2021
View reviewed changes
CDP4Dal/CDPMessageBus.cs Outdated Show resolved Hide resolved
@alexatstariongroup
Copy link
Member

@adrianchivu lets wait for CI to run againm I added a small fix we found that broke coverage stats. After that we can merge and wait for CI again.

Once this is landed @samatrhea can we make a release so that the guys can proceed to make a new SAT package?

@samatstariongroup
Copy link
Member

samatstariongroup commented Jul 8, 2021 •
edited by adrianchivu
Loading

@adrianchivu lets wait for CI to run againm I added a small fix we found that broke coverage stats. After that we can merge and wait for CI again.

Once this is landed @samatrhea can we make a release so that the guys can proceed to make a new SAT package?

yes please

@samatrhea & @alexatrhea thank you for support!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@alexatstariongroup alexatstariongroup merged commit fe5dc96 into development Jul 8, 2021
@alexatstariongroup alexatstariongroup deleted the feature/Support-For-Open-Read-Silently branch July 8, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexatstariongroup alexatstariongroup alexatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

Assignees

@adrianchivu adrianchivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for session open/read silently
3 participants
@adrianchivu @alexatstariongroup @samatstariongroup