Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionService has a bug for write permission in some cases #92

Closed
3 of 10 tasks
IevhenIkonnykov opened this issue Jan 31, 2020 · 1 comment · Fixed by #94
Closed
3 of 10 tasks

PermissionService has a bug for write permission in some cases #92

IevhenIkonnykov opened this issue Jan 31, 2020 · 1 comment · Fixed by #94
Assignees

Comments

@IevhenIkonnykov
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the CDP4-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

PermissionService on lines 398 and 507 does not pass a container of the thing, but the thing itself. It might have happened due to a misleading parameter name for a thing. These lines should be fixed. The fix will produce a test fail in PermissionServiceTestFixture on line 231. Also lines 212 and 213 are identical. On line 212 "CanWrite" method should be substituted with "CanRead".

Steps to Reproduce

See the source code.

System Configuration

Does not matter

  • CDP4 version:
    • CDP4Common:
    • CDP4JsonSerializer:
    • CDP4Dal:
    • CDP4JsonFileDal:
    • CDP4ServicesDal:
    • CDP4WspDal:
    • Other:
  • Environment (Operating system, version and so on):
  • .NET Framework version:
  • Additional information:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants