[Fix] bugs of PermissionService and its test #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IevhenIkonnykov
requested review from
alexatstariongroup and
lxatstariongroup
lxatstariongroup
approved these changes
Feb 5, 2020
|
In principle I have done a thorough review here and it makes sense to me. It seems indeed that the test was wrong. Before merging, we do want to verify in the IME. @lxatrhea can you please do a local nuget test with this branch, and do spot checks in the IME? |
lxatstariongroup
approved these changes
Feb 5, 2020
|
Scoped the test to Finite States (Actual and Possible) and Alias, Hyperlink and Definition data. |
alexatstariongroup
approved these changes
Feb 7, 2020
|
@IevhenIkonnykov approved for merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Closes #92