Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #111 Missing containment type map #112

Closed

Conversation

lxatstariongroup
Copy link
Contributor

@lxatstariongroup lxatstariongroup commented May 20, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the CDP4-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Generated code changes for missing data in containmentTypeMap property of several MetaInfo classes.

Changes are hard to find due to a line ending problem in the old files:

containmentPropertyValueMap and containmentTypeMap properties in:

BookMetaInfo.cs
PageMetaInfo.cs
SectionMetaInfo.cs

The other changes are only header changes,

@lxatstariongroup
Copy link
Contributor Author

lxatstariongroup commented May 20, 2020

Changes are hard to find due to a line ending problem in the old files:

containmentPropertyValueMap and containmentTypeMap properties in:

  • BookMetaInfo.cs
  • PageMetaInfo.cs
  • SectionMetaInfo.cs

The other changes are only header changes,

@samatstariongroup
Copy link
Member

samatstariongroup commented May 20, 2020 via email

@lxatstariongroup
Copy link
Contributor Author

Nothing else has changed such as filestores, LogEntry? Sam Gerené SEMT Business Unit Manager [RHEA GROUP]http://www.rheagroup.com/ RHEA GROUP Schuttersveld 2, 2316 ZA Leiden, The Netherlands Office: +31 71 74 50 000 | Mobile: +31 6 48 31 24 12 www.rheagroup.com<http://www.rheagroup.com/> [Linkedin]https://www.linkedin.com/company/rheagroup [Twitter] https://twitter.com/rheagroup [Description: Skype] skype:sam.gerene From: Alexander van Delft [mailto:[email protected]] Sent: Wednesday, May 20, 2020 4:05 PM To: RHEAGROUP/CDP4-SDK-Community-Edition [email protected] Cc: Sam Gerene [email protected]; Review requested [email protected] Subject: Re: [RHEAGROUP/CDP4-SDK-Community-Edition] Fixes #111 Missing containment type map (#112) Changes are hard to find due to a line ending problem in the old files: containmentPropertyValueMap and containmentTypeMap properties in: * BookMetaInfo.cs: * PageMetaInfo.cs: * SectionMetaInfo.cs: The other changes are only header changes, — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub<#112 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJDRXPO5RXP4UTQZL37RV3RSPPPRANCNFSM4NF5Q5OQ.

No.

@lxatstariongroup lxatstariongroup deleted the fix/GH111-missing-containmentTypeMap branch May 25, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants