Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sonarqube analysis. #122

Merged
merged 13 commits into from
Jul 3, 2020
Merged

Enable sonarqube analysis. #122

merged 13 commits into from
Jul 3, 2020

Conversation

mike-unitskyi
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the CDP4-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

samatstariongroup
samatstariongroup requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understand that the builds are timing out, but we build the SDK's for developers of certain versions of the framework, not to please a build system,. So, please revert and find another solution to build only those targets that have different code paths. You can put on the command line which targets to build for testing and which not

@mike-unitskyi
Copy link
Contributor Author

@samatrhea i just want to investigate if versions of framework are the root cost of timing out. will revert that soon.

samatstariongroup
samatstariongroup requested changes Jul 1, 2020
View reviewed changes
appveyor.yml Outdated
-log:Error
-register
-target:"dotnet"
-targetargs:"test --framework net45 --filter=""(TestCategory!~WebServicesDependent) & (TestCategory!~AppVeyorExclusion)"" --configuration %CONFIGURATION% -v q"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you include one of the netstandard ones here as well. There is a codepath difference between the .NET Framework and .NET Standard

@alexatstariongroup alexatstariongroup mentioned this pull request Jul 3, 2020
Closed
4 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_221) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@alexatstariongroup alexatstariongroup changed the title reduce target frameworks Enable sonarqube analysis. Jul 3, 2020
@alexatstariongroup alexatstariongroup marked this pull request as ready for review July 3, 2020 11:12
@alexatstariongroup alexatstariongroup merged commit 9b7adb6 into development Jul 3, 2020
@alexatstariongroup alexatstariongroup deleted the sonar branch July 3, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samatstariongroup samatstariongroup samatstariongroup requested changes

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mike-unitskyi @samatstariongroup @alexatstariongroup @rheamachineuser