Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] sonarlint configuration to project -> this is to be used in combination with the VS extentions sonarlint #128

Closed
wants to merge 1 commit into from

Conversation

samatstariongroup
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the CDP4-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

I am noticing that we are commiting code to GH and waiting for SonarCloud to provide feedback on where the code needs to be improved. With this plugin, we should be able to run some analysis locally so we speed up the cycle a bit.

The commit contains configuration to be able to connect to a sonarqube server (including sonarcloud). You still have to add a token to your local setup in order to connect.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@samatstariongroup
Copy link
Member Author

@lxatrhea can you approve or reject?

@samatstariongroup samatstariongroup deleted the add-sonar-lint-config branch April 22, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants