Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement migration.json support when importing #141

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Implement migration.json support when importing #141

merged 5 commits into from
Nov 5, 2020

Conversation

adrianchivu
Copy link
Contributor

@adrianchivu adrianchivu commented Oct 20, 2020 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the CDP4-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

@adrianchivu adrianchivu changed the title WIP: Implement migration.json support WIP: Implement migration.json support when importing Oct 20, 2020
@cozminvelciu
Copy link
Contributor

Is this reviewable? I see it still has the WIP tag.

@adrianchivu adrianchivu changed the title WIP: Implement migration.json support when importing Implement migration.json support when importing Oct 30, 2020
@adrianchivu
Copy link
Contributor Author

Is this reviewable? I see it still has the WIP tag.

Ready for review.

cozminvelciu
cozminvelciu suggested changes Oct 30, 2020
View reviewed changes
CDP4JsonFileDal/JsonFileDal.cs Outdated Show resolved Hide resolved
CDP4JsonFileDal/JsonFileDal.cs Outdated Show resolved Hide resolved
CDP4JsonFileDal/JsonFileDal.cs Outdated Show resolved Hide resolved
CDP4JsonFileDal/JsonFileDal.cs Show resolved Hide resolved
CDP4JsonFileDal/JsonFileDal.cs Outdated Show resolved Hide resolved
CDP4JsonFileDal.Tests/files/migration.json Outdated Show resolved Hide resolved
CDP4JsonFileDal.Tests/JsonFileDalTestFixture.cs Show resolved Hide resolved
CDP4JsonFileDal.Tests/JsonFileDalTestFixture.cs Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@adrianchivu adrianchivu merged commit 6dcbfe9 into development Nov 5, 2020
@adrianchivu adrianchivu deleted the feat/GH16-Implement-migration.json-support branch November 5, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexatstariongroup alexatstariongroup alexatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

@cozminvelciu cozminvelciu Awaiting requested review from cozminvelciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianchivu @cozminvelciu @samatstariongroup @alexatstariongroup