[Add] QueryReferencedThings() and QueryReferencedThingsDeep() methods to the abstract Thing class #143
Conversation
… to the abstract Thing class
| { | ||
| var temp = new List<Thing>(); | ||
|
|
||
| foreach (var thing in this.QueryReferencedThings()) |
There was a problem hiding this comment.
For QueryReferencedThingsDeep, I was thinking of returning the list of objects referenced from the full containment [sub]tree, not a tree of referenced things: so iterating through this.ContainerList, not the referenced things.
For the full tree of things "connected" to the current thing, we would indeed interate through both contained and referenced things.
samatstariongroup
changed the title
CDP4Common/Poco/Thing.cs
Outdated
| /// this does not include the contained <see cref="Thing"/>s, the contained <see cref="Thing"/>s | ||
| /// are exposed via the <see cref="ContainerLists"/> method | ||
| /// </remarks> | ||
| /// <returns></returns> |
|
just added the code-generated QueryReferencedThing method. I am not sure the requested method to query all so-called |
|
SonarCloud Quality Gate failed.
|
| yield return thing; | ||
| } | ||
|
|
||
| foreach (var thing in this.BaseQuantityKind.Select(x => x)) |
There was a problem hiding this comment.
I noticed that for some things (most don't have this) that are iterated there's an additional .Select(x =>x). Does this serve any purpose? It seems to me like it's adding [execution] complexity for nothing.
There was a problem hiding this comment.
It is required to handle ordereditemlist
CDP4Common/AutoGenPoco/ValueGroup.cs
Outdated
| /// Queries the referenced <see cref="Thing"/>s of the current <see cref="ValueGroup"/> | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// this does not include the contained <see cref="Thing"/>s, the contained <see cref="Thing"/>s |
There was a problem hiding this comment.
Nitpick: this might be better to start with a capital "T".
CDP4Common/AutoGenPoco/ValueGroup.cs
Outdated
| /// </summary> | ||
| /// <remarks> | ||
| /// this does not include the contained <see cref="Thing"/>s, the contained <see cref="Thing"/>s | ||
| /// are exposed via the <see cref="ContainerLists"/> method |
There was a problem hiding this comment.
Nitpick: ContainerLists is actually a property.
Prerequisites
Description
Added 2 methods on
Thingclass to enable future work on querying referenced things: