Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#203 Using SAT to migrate models(Take into account the DefaultDomain of the included Person objects) #188

Merged
merged 10 commits into from
May 18, 2021
Merged

#203 Using SAT to migrate models(Take into account the DefaultDomain of the included Person objects) #188

merged 10 commits into from
May 18, 2021

Conversation

adrianchivu
Copy link
Contributor

@adrianchivu adrianchivu commented May 11, 2021 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Make the pruning algorithm (in either JsonFileDalUtils.AddDomainsOfExpertise or JsonFileDalUtils.AddPersons) also take into account the DefaultDomain of the included Person object.

@adrianchivu adrianchivu self-assigned this May 11, 2021
@adrianchivu adrianchivu marked this pull request as draft May 11, 2021 15:23
@adrianchivu adrianchivu changed the title #203 Using sat to migrate models(Take into account the DefaultDomain of the included Person objects) #203 Using SAT to migrate models(Take into account the DefaultDomain of the included Person objects) May 11, 2021
@adrianchivu adrianchivu marked this pull request as ready for review May 11, 2021 15:52
@adrianchivu adrianchivu requested a review from cozminvelciu May 11, 2021 15:52
alexatstariongroup
alexatstariongroup requested changes May 12, 2021
View reviewed changes
Copy link
Member

@alexatstariongroup alexatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more correct conjugation.

CDP4JsonFileDal/JsonFileDal.cs Outdated Show resolved Hide resolved
CDP4JsonFileDal/JsonFileDalUtils.cs Outdated Show resolved Hide resolved
@cozminvelciu
Copy link
Contributor

Fixes STARIONGROUP/COMET-WebServices-Community-Edition#203

@cozminvelciu cozminvelciu added this to the sprint 33 milestone May 12, 2021
cozminvelciu
cozminvelciu suggested changes May 12, 2021
View reviewed changes
CDP4JsonFileDal/JsonFileDalUtils.cs Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@adrianchivu adrianchivu merged commit c3b67e5 into development May 18, 2021
@adrianchivu adrianchivu deleted the feat/GH203-Using-SAT-to-migrate-models branch May 18, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cozminvelciu cozminvelciu cozminvelciu approved these changes

@alexatstariongroup alexatstariongroup alexatstariongroup approved these changes

@lxatstariongroup lxatstariongroup Awaiting requested review from lxatstariongroup

Assignees

@adrianchivu adrianchivu

Labels
CDF SDK
Projects
COMET-CE
Archived in project
Milestone
sprint 33
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianchivu @cozminvelciu @alexatstariongroup @lxatstariongroup