Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCD PR For Nuget - DO NOT MERGE #210

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from
Draft

Conversation

alexatstariongroup
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

CDP4Common/AutoGenDto/ArchitectureDiagram.cs Show resolved Hide resolved
CDP4Dal/CDP4Dal.csproj Outdated Show resolved Hide resolved
CDP4ServicesDal/CDP4ServicesDal.csproj Outdated Show resolved Hide resolved
CDP4WspDal/CDP4WspDal.csproj Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

41.7% 41.7% Coverage
0.0% 0.0% Duplication

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 and others added 2 commits May 30, 2022 09:41
Header versions update

Wrong Participant Permission on Behavior

More forgotten participant permissions for Behaviors

Fixed interface for attachments and DAL handling of file verification

Architecture Diagram must have own permission set to support Modify if owned

Attachment finetuning (#203)

* Add Path property to Attachment
* Implement Attachment functionality
* Version bump
* Code review changes
* Fix according to review

Participant Role test and session fix (#204)

* Participant Role test and session fix
* Refactor CanCancel and Cancel using only thread safe methods

ignore file updates

Bumped version number

Model version 1.3.17

Wrong Participant Permission on Behavior

More forgotten participant permissions for Behaviors

Architecture Diagram must have own permission set to support Modify if owned

Version bump

Bump versions

Revert "Bumped version number"

This reverts commit c7b101e.

Fixed version numbers
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

41.7% 41.7% Coverage
0.0% 0.0% Duplication

@alexatstariongroup alexatstariongroup marked this pull request as draft June 13, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants