Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 8.2.0 - DO NOT MERGE #225

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Version 8.2.0 - DO NOT MERGE #225

merged 3 commits into from
Feb 1, 2022

Conversation

alexatstariongroup
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Merge to master for the last non-GCD version to be released

@alexatstariongroup alexatstariongroup mentioned this pull request Feb 1, 2022
Open
17 tasks
lxatstariongroup
lxatstariongroup reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@lxatstariongroup lxatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Requirements project should have a major version upgrade, because the API changed there. But then it goes from 0.. to 1.., which means "out of beta".

@alexatstariongroup
Copy link
Member Author

I think that Requirements project should have a major version upgrade, because the API changed there. But then it goes from 0.. to 1.., which means "out of beta".

you only have backwards compatible changes though. so it is correct, no?

@lxatstariongroup
Copy link
Contributor

I think that Requirements project should have a major version upgrade, because the API changed there. But then it goes from 0.. to 1.., which means "out of beta".

you only have backwards compatible changes though. so it is correct, no?

No, constructors of all ExpressionVerifiers have changed. So it's not backwards compatible.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.7% 69.7% Coverage
0.0% 0.0% Duplication

@alexatstariongroup alexatstariongroup merged commit 41de278 into master Feb 1, 2022
@github-pages github-pages bot temporarily deployed to github-pages February 1, 2022 16:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxatstariongroup lxatstariongroup lxatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexatstariongroup @lxatstariongroup @samatstariongroup