[Add] MessagePack serialization implementation #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samatstariongroup
requested review from
alexatstariongroup,
lxatstariongroup and
nathanatstariongroup
added 5 commits
July 29, 2023 19:31
…erialize and deserialize the value of an OrderedItem as string (same as in JSON serializer)
nathanatstariongroup
approved these changes
Jul 31, 2023
CDP4ServicesDal/CdpServicesDal.cs
Outdated
| @@ -172,8 +196,18 @@ public override async Task<IEnumerable<Thing>> Write(OperationContainer operatio | |||
|
|
|||
| using (var resultStream = await httpResponseMessage.Content.ReadAsStreamAsync()) | |||
| { | |||
| result.AddRange(this.Serializer.Deserialize(resultStream)); | |||
|
|
|||
| switch (this.QueryConentTypeKind(httpResponseMessage)) | |||
There was a problem hiding this comment.
Typo in the method name
alexatstariongroup
approved these changes
Jul 31, 2023
|
SonarCloud Quality Gate failed.
|
lxatstariongroup
approved these changes
Jul 31, 2023
|
implemented in b83f01d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds a MessagePack serilzation capability to the CDP4-COMET SDK. It includes a new Project in which this serializer is implemented. Most of the code is code-generated.
Please have a look at the generated code as well as the changes to CDP4SerivesDal that makes use of messagepack serializer to deserialize the content of the HTTP response based on the CONTENT-TYPE header