Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #321: TypeInitializer and PropertyAccessor setter #322

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Fix #321: TypeInitializer and PropertyAccessor setter #322

merged 3 commits into from
Mar 11, 2024

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #321

  • TypeInitializer allow to initialize any Thing based on its ClassKind
  • PropertyAccessor setter
  • unit tests for PropertyAccessor setter, each case tested, not done for every properties of every class

samatstariongroup
samatstariongroup approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did spot checks, looks good to me

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
65.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@antoineatstariongroup antoineatstariongroup merged commit 393c050 into development Mar 11, 2024
3 of 5 checks passed
@antoineatstariongroup antoineatstariongroup deleted the feat/GH321-helper-functionalities-for-csv branch March 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samatstariongroup samatstariongroup samatstariongroup approved these changes

@lxatstariongroup lxatstariongroup Awaiting requested review from lxatstariongroup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helper class and functionalities for CSV import purpose
2 participants
@antoineatstariongroup @samatstariongroup