Fix #326: Allow to have space before/after | for enums #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineatstariongroup
requested review from
samatstariongroup and
lxatstariongroup
lxatstariongroup
approved these changes
Apr 9, 2024
samatstariongroup
requested changes
Apr 9, 2024
|
|
||
| for (var valueIndex = 0; valueIndex < values.Length; valueIndex++) | ||
| { | ||
| values[valueIndex] = Regex.Replace(values[valueIndex], @"^\s*|\s*$", ""); |
There was a problem hiding this comment.
please use .Trim() instead of regex. I think Trim does what you want and is also faster (not that this gets called so many times) than a regex
|
samatstariongroup
approved these changes
Apr 9, 2024
antoineatstariongroup
deleted the
bug/gh326-support-of-spaced-separator-enumeration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #326
Space before/after the '|' separator for multi-values enumeration is now allowed