OrderedItemList is not properly cloned. Assembler preserves the state…

[IevhenIkonnykov]

… of OrderedItemList.

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following the CDP4-SDK code style guidelines
• I have provided test coverage for my change (where applicable)

Description

It looks like Assembler preserves keys of OrderedItemLists properly, but once an OrderedItemList is cloned then a clone gets absolutely new keys that are not synchronized with the original object. Two tests are added to prove this. An example of where OrderedItemList is cloned here. It is clear that it adds new items and for each new item a new key is generted. That is why keys are not synchronized.

[samatstariongroup]

@IevhenIkonnykov do you propose we refactor the cloning of the OrderedItemList so that keys are preserved?

[samatstariongroup]

I've done some looking at the code, and indeed, the clone method of for instance PossibleFiniteStateList. I noticed that the GenericClone method (on line 171) does the the following:

clone.PossibleState.AddRange(this.PossibleState.Select(x => x.Clone(true)));

the AddRangemethod indeed generates new keys. I think in this case we should not use AddRange as is. Perhaps we can add a Clone method to the OrderedItemList and use that one instead. Whatever the fix, it will involve code generation (not a problem of course).

[IevhenIkonnykov]

I also think that adding a clone method to OrderedItemList and regeneration of existing code is a better solution.
I am curious how OrderedItemList is handled now in IME if clone produces new keys. There should be some workaround. Maybe it is elegant and I could use it in the sample app. Could you point me to the code where I could see it?

[samatstariongroup]

I don't think we do any special handling in the IME. We just do a clone, add that to the Operation/Transation and that's it. It seems that what is happening now is that we are sending new keys to the server every single time we update a Thing that has a property of OrderedItemList<T>. Which is not correct as you have spotted and we need to fix.

[samatstariongroup]

missing header

[samatstariongroup]

using statements go inside namespace