Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH96: read and cache revisions #97

Merged
merged 9 commits into from
Mar 16, 2020
Merged

GH96: read and cache revisions #97

merged 9 commits into from
Mar 16, 2020

Conversation

lxatstariongroup
Copy link
Contributor

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the CDP4-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Revisions are now stored in the cache correctly.

Alexander van Delft added 5 commits February 24, 2020 14:40
Extra revision functionality
0d3cac8 
- save revisions even when the revision is older than the current cached revision
- Implement read specific revisions by a thing's route/uri
Bump versions for proper pre-release usage
80f27c2
Remove ReadByRoute options
538ec64
Added unit tests and resolve related bugs
a736b98
Some administrative fixes
254c529
@lxatstariongroup lxatstariongroup self-assigned this Mar 6, 2020
samatstariongroup
samatstariongroup reviewed Mar 9, 2020
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, some improvements requested

CDP4Common/Helpers/PocoThingFactory.cs Outdated Show resolved Hide resolved
CDP4Dal/Assembler.cs Outdated Show resolved Hide resolved
CDP4Dal/Assembler.cs Outdated Show resolved Hide resolved
samatstariongroup
samatstariongroup approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix final comments, no need for extra review

CDP4ServicesDal/CdpServicesDal.cs Outdated Show resolved Hide resolved
CDP4RequirementsVerification/Verifiers/BooleanExpressionVerifier.cs Show resolved Hide resolved
@samatstariongroup
Copy link
Member

@alexatrhea can you update the docs on the wiki as well to reflect the changes you have made to the ISession interface and Session class? https://github.com/RHEAGROUP/CDP4-SDK-Community-Edition/wiki/Session

@alexatstariongroup
Copy link
Member

@lxatrhea

@lxatstariongroup lxatstariongroup merged commit f706c06 into development Mar 16, 2020
@lxatstariongroup lxatstariongroup deleted the feat/GH96-read-revisions branch March 16, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanatstariongroup nathanatstariongroup nathanatstariongroup approved these changes

@alexatstariongroup alexatstariongroup alexatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

@mmilitaru mmilitaru Awaiting requested review from mmilitaru

@kamilatrhea kamilatrhea Awaiting requested review from kamilatrhea

Assignees

@lxatstariongroup lxatstariongroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lxatstariongroup @samatstariongroup @alexatstariongroup @nathanatstariongroup