Skip to content
Build & Test & SonarQube

server admin page is now tabbed + unit tests fixed #2443

Sign in to view logs

server admin page is now tabbed + unit tests fixed

server admin page is now tabbed + unit tests fixed #2443

Triggered via push July 22, 2024 09:06
@joao4alljoao4all
pushed 5cc168a
feat/GH699-one-tab-bar-for-the-whole-app-and-not-per-view
Status Success
Total duration 3m 25s
Artifacts –

CodeQuality.yml

on: push
Build
3m 13s
Build
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Build: COMET.Web.Common/Components/DisposableComponent.razor.cs#L33
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
Build: COMET.Web.Common/Utilities/DisposableObject/DisposableObject.cs#L33
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
Build: COMET.Web.Common/ViewModels/Components/Applications/ApplicationBaseViewModel.cs#L44
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
Build: COMET.Web.Common/Extensions/SessionServiceExtensions.cs#L50
Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457)
Build: COMET.Web.Common/Components/ParameterTypeEditors/CompoundParameterTypeEditor.razor#L35
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
Build: COMETwebapp/Program.cs#L44
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
Build: COMETwebapp/Components/Common/ThingOrderedItemsTable.razor.cs#L42
Reduce the number of generic parameters in the 'ThingOrderedItemsTable' class to no more than the 2 authorized. (https://rules.sonarsource.com/csharp/RSPEC-2436)
Build: COMETwebapp/Components/Shared/About.razor.cs#L39
Refactor your code not to use hardcoded absolute paths or URIs. (https://rules.sonarsource.com/csharp/RSPEC-1075)
Build: COMETwebapp/ViewModels/Components/Viewer/PropertiesPanel/PropertiesComponentViewModel.cs#L218
Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
Build: COMETwebapp/ViewModels/Components/Viewer/PropertiesPanel/PropertiesComponentViewModel.cs#L274
Remove this unnecessary check for null. (https://rules.sonarsource.com/csharp/RSPEC-2589)