Skip to content

Feat/SessionServiceImprovements. Fix #489 #1587

Feat/SessionServiceImprovements. Fix #489

Feat/SessionServiceImprovements. Fix #489 #1587

Triggered via pull request December 6, 2023 09:54
Status Failure
Total duration 1m 32s
Artifacts

CodeQuality.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 10 warnings
Build: COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L63
There is no argument given that corresponds to the required parameter 'logger' of 'SessionService.SessionService(ILogger<SessionService>)'
Build: COMETwebapp.Tests/Components/SystemRepresentation/SystemRepresentationBodyTestFixture.cs#L80
There is no argument given that corresponds to the required parameter 'logger' of 'SessionService.SessionService(ILogger<SessionService>)'
Build: COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L63
There is no argument given that corresponds to the required parameter 'logger' of 'SessionService.SessionService(ILogger<SessionService>)'
Build: COMETwebapp.Tests/Components/SystemRepresentation/SystemRepresentationBodyTestFixture.cs#L80
There is no argument given that corresponds to the required parameter 'logger' of 'SessionService.SessionService(ILogger<SessionService>)'
Build
Process completed with exit code 1.
Build: COMET.Web.Common/App.razor.cs#L92
Dispose 'cancellationTokenSource' when it is no longer needed. (https://rules.sonarsource.com/csharp/RSPEC-2930)
Build: COMET.Web.Common/Utilities/DisposableObject/DisposableObject.cs#L33
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
Build: COMET.Web.Common/Components/DisposableComponent.razor.cs#L33
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
Build: COMET.Web.Common/Extensions/SessionServiceExtensions.cs#L47
Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457)
Build: COMET.Web.Common/Extensions/SessionServiceExtensions.cs#L90
The parameter name 'Session' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
Build: COMET.Web.Common/Extensions/SessionServiceExtensions.cs#L71
Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457)
Build: COMET.Web.Common/Extensions/GuidExtensions.cs#L143
Split this method into two, one handling parameters check and the other handling the iterator. (https://rules.sonarsource.com/csharp/RSPEC-4456)
Build: COMET.Web.Common/ViewModels/Components/ParameterEditors/EnumerationParameterTypeEditorViewModel.cs#L121
Change this condition so that it does not always evaluate to 'True'. (https://rules.sonarsource.com/csharp/RSPEC-2589)
Build: COMET.Web.Common/Components/ParameterTypeEditors/CompoundParameterTypeEditor.razor#L35
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
Build: COMETwebapp/Program.cs#L63
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)