partially refactored code #1971
joao4allAnnotations
10 errors and 10 warnings
|
Build:
COMET.Web.Common.Tests/Extensions/SessionServiceExtensionsTestFixture.cs#L59
Property or indexer 'SessionService.Session' cannot be assigned to -- it is read only
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L75
Property or indexer 'SessionService.Session' cannot be assigned to -- it is read only
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/AuthenticationServiceTestFixture.cs#L87
'AuthenticationService' does not contain a constructor that takes 3 arguments
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/AuthenticationServiceTestFixture.cs#L91
'ISessionService' does not contain a definition for 'Close' and no accessible extension method 'Close' accepting a first argument of type 'ISessionService' could be found (are you missing a using directive or an assembly reference?)
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L167
Property or indexer 'SessionService.IsSessionOpen' cannot be assigned to -- it is read only
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L169
'SessionService' does not contain a definition for 'Close' and no accessible extension method 'Close' accepting a first argument of type 'SessionService' could be found (are you missing a using directive or an assembly reference?)
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L174
'SessionService' does not contain a definition for 'Close' and no accessible extension method 'Close' accepting a first argument of type 'SessionService' could be found (are you missing a using directive or an assembly reference?)
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L178
'SessionService' does not contain a definition for 'Close' and no accessible extension method 'Close' accepting a first argument of type 'SessionService' could be found (are you missing a using directive or an assembly reference?)
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L180
Property or indexer 'SessionService.IsSessionOpen' cannot be assigned to -- it is read only
|
|
Build:
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs#L181
'SessionService' does not contain a definition for 'Close' and no accessible extension method 'Close' accepting a first argument of type 'SessionService' could be found (are you missing a using directive or an assembly reference?)
|
|
Build:
COMET.Web.Common/Utilities/DisposableObject/DisposableObject.cs#L33
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
|
|
Build:
COMET.Web.Common/Components/DisposableComponent.razor.cs#L33
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
|
|
Build:
COMET.Web.Common/Extensions/SessionServiceExtensions.cs#L69
The parameter name 'Session' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
|
|
Build:
COMET.Web.Common/Extensions/SessionServiceExtensions.cs#L50
Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457)
|
|
Build:
COMET.Web.Common/Components/ParameterTypeEditors/CompoundParameterTypeEditor.razor#L35
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
|
|
Build:
COMETwebapp/Program.cs#L43
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
|
|
Build:
COMETwebapp/Components/Shared/About.razor.cs#L39
Refactor your code not to use hardcoded absolute paths or URIs. (https://rules.sonarsource.com/csharp/RSPEC-1075)
|
|
Build:
COMETwebapp/ViewModels/Components/Viewer/PropertiesPanel/PropertiesComponentViewModel.cs#L215
Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Build:
COMETwebapp/ViewModels/Components/Viewer/PropertiesPanel/PropertiesComponentViewModel.cs#L271
Remove this unnecessary check for null. (https://rules.sonarsource.com/csharp/RSPEC-2589)
|
|
Build:
COMETwebapp/Components/ModelDashboard/ParameterValues/ParameterDomainProgress.razor#L62
Use '.Any()' to test whether this 'IEnumerable<string>' is empty or not. (https://rules.sonarsource.com/csharp/RSPEC-1155)
|