Final SQ Comments

STARIONGROUP · Jan 6, 2025 · 269dcdc · 269dcdc
1 parent fe557d0
commit 269dcdc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/COMET.Web.Common/Utilities/ThingCreator.cs b/COMET.Web.Common/Utilities/ThingCreator.cs
@@ -61,7 +61,7 @@ public Task CreateElementUsageAsync(ElementDefinition container, ElementDefiniti
             ArgumentNullException.ThrowIfNull(owner);
             ArgumentNullException.ThrowIfNull(session);
 
-            return this.CreateElementUsageImplAsync(container, referencedDefinition, owner, session);
+            return CreateElementUsageImplAsync(container, referencedDefinition, owner, session);
         }
 
         /// <summary>
@@ -79,7 +79,7 @@ public Task CreateElementUsageAsync(ElementDefinition container, ElementDefiniti
         /// <param name="session">
         /// The <see cref="ISession"/> in which the current <see cref="Parameter"/> is to be added
         /// </param>
-        private async Task CreateElementUsageImplAsync(ElementDefinition container, ElementDefinition referencedDefinition, DomainOfExpertise owner, ISession session)
+        private static async Task CreateElementUsageImplAsync(ElementDefinition container, ElementDefinition referencedDefinition, DomainOfExpertise owner, ISession session)
         {
             var clone = container.Clone(false);
 

diff --git a/COMETwebapp/Components/MultiModelEditor/ElementDefinitionTree.razor b/COMETwebapp/Components/MultiModelEditor/ElementDefinitionTree.razor
@@ -78,7 +78,7 @@ else
                 @dataItem.ElementName <span>
                     <button class="starion-pill" title="Owning Domain Of Expertise: @dataItem.OwnerShortName">@dataItem.OwnerShortName</button>
                 </span>
-                @foreach (var categoryShortName in @dataItem.ElementBase.GetAllCategories().Select(x => x.ShortName))
+                @foreach (var categoryShortName in dataItem.ElementBase.GetAllCategories().Select(x => x.ShortName))
                 {
                     <span>
                         <button class="starion-pill" style="background-color:aliceblue !important;" title="Category: @categoryShortName">@categoryShortName</button>
@@ -92,7 +92,7 @@ else
                 @dataItem.ElementName <span>
                     <button class="starion-pill" title="Owning Domain Of Expertise: @dataItem.OwnerShortName">@dataItem.OwnerShortName</button>
                 </span>
-                @foreach (var categoryShortName in @dataItem.ElementBase.GetAllCategories().Select(x => x.ShortName))
+                @foreach (var categoryShortName in dataItem.ElementBase.GetAllCategories().Select(x => x.ShortName))
                 {
                     <span>
                         <button class="starion-pill" style="background-color:aliceblue !important;" title="Category: @categoryShortName">@categoryShortName</button>

diff --git a/COMETwebapp/ViewModels/Components/MultiModelEditor/ElementDefinitionTreeViewModel.cs b/COMETwebapp/ViewModels/Components/MultiModelEditor/ElementDefinitionTreeViewModel.cs
@@ -36,7 +36,6 @@ namespace COMETwebapp.ViewModels.Components.MultiModelEditor
     using COMET.Web.Common.Services.SessionManagement;
     using COMET.Web.Common.ViewModels.Components.Applications;
 
-    using COMETwebapp.Components.ModelEditor;
     using COMETwebapp.Components.MultiModelEditor;
     using COMETwebapp.ViewModels.Components.ModelEditor;
     using COMETwebapp.ViewModels.Components.MultiModelEditor.Rows;
@@ -125,12 +124,12 @@ public IterationData SelectedIterationData
         /// <summary>
         /// All <see cref="ElementBase" /> of the iteration
         /// </summary>
-        public List<ElementBase> Elements { get; set; } = [];
+        public List<ElementBase> Elements { get; private set; } = [];
 
         /// <summary>
         /// Gets the collection of the <see cref="ElementDefinitionTreeTreeRowViewModel" /> for target model
         /// </summary>
-        public ObservableCollection<ElementDefinitionTreeTreeRowViewModel> Rows { get; set; } = [];
+        public ObservableCollection<ElementDefinitionTreeTreeRowViewModel> Rows { get; private set; } = [];
 
         /// <summary>
         /// Represents the selected ElementDefinitionRowViewModel

diff --git a/COMETwebapp/ViewModels/Components/MultiModelEditor/IElementDefinitionTreeViewModel.cs b/COMETwebapp/ViewModels/Components/MultiModelEditor/IElementDefinitionTreeViewModel.cs
@@ -41,7 +41,7 @@ public interface IElementDefinitionTreeViewModel : IHaveReusableRows
         /// <summary>
         /// Gets the collection of the <see cref="ElementDefinitionTreeTreeRowViewModel" />
         /// </summary>
-        ObservableCollection<ElementDefinitionTreeTreeRowViewModel> Rows { get; set; }
+        ObservableCollection<ElementDefinitionTreeTreeRowViewModel> Rows { get; }
 
         /// <summary>
         /// The <see cref="Iteration"/> from which to build the tree