Changes according to SQ

STARIONGROUP · Dec 9, 2024 · 3eb60ec · 3eb60ec
1 parent ef59fa4
commit 3eb60ec
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/COMET.Web.Common/Services/Cache/CacheService.cs b/COMET.Web.Common/Services/Cache/CacheService.cs
@@ -36,7 +36,7 @@ public class CacheService : ICacheService
         /// <summary>
         /// Holds all the settings that can be used during the browser session's lifetime to make the user's experience better
         /// </summary>
-        private ConcurrentDictionary<BrowserSessionSettingKey, object> browserSessionSettings = new();
+        private readonly ConcurrentDictionary<BrowserSessionSettingKey, object> browserSessionSettings = new();
 
         /// <summary>
         /// Tries to get a stored value in the BrowserSessionSettings Dictionary

diff --git a/COMET.Web.Common/ViewModels/Components/OpenModelViewModel.cs b/COMET.Web.Common/ViewModels/Components/OpenModelViewModel.cs
@@ -240,7 +240,7 @@ public virtual async Task<Result<Iteration>> OpenSession()
         /// <param name="domainId">The <see cref="Guid" /> of the <see cref="DomainOfExpertise" /> to select</param>
         public void PreSelectIteration(Guid modelId, Guid iterationId, Guid domainId)
         {
-            if (!this.cacheService.TryGetBrowserSessionSetting(BrowserSessionSettingKey.LastUsedIterationData, out var lastSelectedIterationData))
+            if (!this.cacheService.TryGetBrowserSessionSetting(BrowserSessionSettingKey.LastUsedIterationData, out _))
             {
                 this.selectedEngineeringModel = this.sessionService.OpenEngineeringModels.FirstOrDefault(x => x.Iid == modelId)?.EngineeringModelSetup;
                 var iterationSetup = this.SelectedEngineeringModel?.IterationSetup.Find(x => x.IterationIid == iterationId);

diff --git a/COMETwebapp/ViewModels/Pages/TabsViewModel.cs b/COMETwebapp/ViewModels/Pages/TabsViewModel.cs
@@ -47,11 +47,6 @@ public class TabsViewModel : DisposableObject, ITabsViewModel
         /// </summary>
         private readonly IServiceProvider serviceProvider;
 
-        /// <summary>
-        /// Gets the injected <see cref="ICacheService" />
-        /// </summary>
-        private readonly ICacheService cacheService;
-
         /// <summary>
         /// Gets the injected <see cref="ISessionService" />
         /// </summary>
@@ -72,7 +67,6 @@ public TabsViewModel(ISessionService sessionService, IServiceProvider servicePro
         {
             this.sessionService = sessionService;
             this.serviceProvider = serviceProvider;
-            this.cacheService = cacheService;
             this.Disposables.Add(this.WhenAnyValue(x => x.SelectedApplication).Subscribe(_ => this.OnSelectedApplicationChange()));
             this.Disposables.Add(this.WhenAnyValue(x => x.MainPanel.CurrentTab).Subscribe(_ => this.OnCurrentTabChange(this.MainPanel)));
             this.Disposables.Add(this.WhenAnyValue(x => x.SidePanel.CurrentTab).Subscribe(_ => this.OnCurrentTabChange(this.SidePanel)));